feat(ivc): sfc input design #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosma
reviewed
Nov 22, 2024
cyphersnake
force-pushed
the
371-support-circuit-2
branch
from
51d6bd1 to
0154593
Compare
cyphersnake
force-pushed
the
369-sfc-1
branch
from
3a2196a to
ee00d0e
Compare
chaosma
reviewed
Nov 29, 2024
| // CMain::Base or CSupport::Scalar (native for suppport_circuit) | ||
| let support_circuit_instances: Vec<Vec<CMain::Base>> = support_circuit::InstanceInput { | ||
| p0: CMain::identity(), | ||
| l0: CMain::Base::ZERO, |
There was a problem hiding this comment.
when we do folding, we only need one scalar mul at a time. so we can save one scalar mul.
i.e.
p0+p1*l1 -> pout
| } | ||
|
|
||
| /// Recursive trace of the circuit itself | ||
| pub struct SelfTrace<F: PrimeField> { |
There was a problem hiding this comment.
NBD (for naming): usually, when we say a trace to indicate it is witness+instance.
Here the trace is set of all the instances of accumulator and incoming
chaosma
approved these changes
Dec 2, 2024
**Motivation** Part of #369 **Overview** This PR is intended to demonstrate the `Input` design for `cyclefold::StepFoldingCircuit` Note what types are used, what curves are presented and how this data is assumed to be reported inside the circuit
**Motivation** **Overview**
**Motivation** Within #369 and cyclfold in general we need to count consistency markers, for this we need to be able to absorb sfc::input **Overview** Just implementation of `AbsorbInRO` trait for all sfc::input types
cyphersnake
force-pushed
the
369-sfc-1
branch
from
ee00d0e to
cf65144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #369
Overview
This PR is intended to demonstrate the
Inputdesign forcyclefold::StepFoldingCircuitNote what types are used, what curves are presented and how this data is
assumed to be reported inside the circuit