Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ivc): cyclefold::sfc ro_absorb #394

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat(ivc): cyclefold::sfc ro_absorb #394

merged 1 commit into from
Dec 3, 2024

Conversation

cyphersnake
Copy link
Collaborator

Motivation
Within #369 and cyclfold in general we need to count consistency markers, for this we need to be able to absorb sfc::input

Overview
Just implementation of AbsorbInRO trait for all sfc::input types

@cyphersnake cyphersnake requested a review from chaosma November 28, 2024 16:23
@cyphersnake
Copy link
Collaborator Author

Our CI always uses the stable version of Rust, so I had to update to 1.83 and fix some lint. You can ignore the last commit, it contains no changes other than cosmetic ones

@cyphersnake cyphersnake self-assigned this Nov 28, 2024
Copy link
Collaborator

@chaosma chaosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from 369-sfc-1 to main December 3, 2024 10:58
@cyphersnake cyphersnake merged commit af785de into main Dec 3, 2024
1 check passed
@cyphersnake cyphersnake deleted the 369-sfc-2 branch December 3, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants