feat: nifs::protogalaxy from C::Base to C::Scalar
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosma
reviewed
Dec 2, 2024
cyphersnake
force-pushed
the
369-sfc-3
branch
from
62f2156 to
a3f2062
Compare
cyphersnake
force-pushed
the
369-sfc-4
branch
from
006723b to
7043ee7
Compare
**Motivation** We need consistent types for #369 between nifs <-> ivc protogalaxy modules **Overview** I had to make many types independent of the curve. Since for the random oracle logic we are byte-by-by-byte distilling from all fields to the target field anyway, I got rid of Scalar -> Base in favor of any field. So now it can be both C::Base (for sangria) and C::Scalar (for cyclefold) There are no other functional changes, only generic refactoring
cyphersnake
force-pushed
the
369-sfc-4
branch
from
7043ee7 to
53ec4a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need consistent types for #369 between nifs <-> ivc protogalaxy modules
Overview
I had to make many types independent of the curve. Since for the random oracle logic we are byte-by-by-byte distilling from all fields to the target field anyway, I got rid of Scalar -> Base in favor of any field.
So now it can be both C::Base (for sangria) and C::Scalar (for cyclefold)
There are no other functional changes, only generic refactoring