feat(ivc): impl cyclefold::sfc verify protogalaxy #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphersnake
force-pushed
the
369-sfc-4
branch
from
006723b to
7043ee7
Compare
cyphersnake
force-pushed
the
369-sfc-5
branch
from
2bc60b5 to
caeee87
Compare
chaosma
reviewed
Dec 5, 2024
| |region| { | ||
| let mut region = RegionCtx::new(region, 0); | ||
|
|
||
| protogalaxy::verify_chip::verify( |
There was a problem hiding this comment.
Since the verify_chip contains ecc operations, it seems we need to provide the result of ecc operations as advice input?
There was a problem hiding this comment.
No, we can take W_commitment from paired_trace.
I already made this is future PR's (
sirius/src/ivc/cyclefold/sfc/mod.rs
Lines 167 to 172 in 46b656c
chaosma
approved these changes
Dec 5, 2024
cyphersnake
force-pushed
the
369-sfc-4
branch
from
7043ee7 to
53ec4a8
Compare
**Motvation** As part of the sfc implementation (#369), we call `protogalaxy::verify_chip` for its own trace, among other things **Overview** Since ivc::protogalaxy & ivc::cyclefold are independent types, we have structures that are independent of each other, yet similar one to one. We need to cast them to an equivalent form (`BigUintPoint`) - [ ] WIP: W_commitment to BigUintPoint in both structure
**Motivation** During the implementation of #369, the types for protogalaxy & cyclefold differed in form but not in substance **Overview** Simple refactoring with removing identical structures and using in ivc::cyclefold types from ivc::protogalaxy
cyphersnake
force-pushed
the
369-sfc-5
branch
from
caeee87 to
a8b7be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motvation
As part of the sfc implementation (#369), we call
protogalaxy::verify_chipfor its own trace, among other thingsOverview
Since ivc::protogalaxy & ivc::cyclefold are independent types, we have structures that are independent of each other, yet similar one to one. We need to cast them to an equivalent form (
BigUintPoint)