-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nifs): protogalaxy initial acc #412
Conversation
Warning Rate limit exceeded@cyphersnake has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 31 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
impl<F: PrimeField> Challenges<F> { | ||
#[instrument(skip_all)] | ||
pub(crate) fn generate_one<'i, D: PrimeField, RO: ROTrait<D>, C: CurveAffine>( | ||
fn generate_one<'i, D: PrimeField, RO: ROTrait<D>, C: CurveAffine>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NBD: this name might be confused with generate output=1 instead generate one random number
4ad26ad
to
830f357
Compare
**Motivation** ProtoGalaxy accumulator was created immediately by `!is_sat`, which prevents folding in #373 **Overview** - The protogalaxy accumulator logic has been changed - AssignedBigUint within ivc::protogalaxy is now an array. This generated a certain number of try_into().unwrap(), however, these will be cleaned up soon - Changed the order of absorption in ro, for consistency with cyclefold
6070ee5
to
3e403d5
Compare
Motivation
ProtoGalaxy accumulator was created immediately by
!is_sat
, which prevents folding in #373Overview