-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dmd -run
instead of rdmd
#327
base: master
Are you sure you want to change the base?
Conversation
Suspicious enough, it passes the CI tests (unlike other PRs)… |
I'm just seeing this now, because github's UI is nothing short of complete garbage. Let me try this. |
vs
Where does the difference come from? |
It also seems to be significantly slower. I get 4s for the former vs 7s for the later. |
When invoked from the makefile or a raw command? If the former then it may be because rdmd caches and dmd -run obviously won't. |
Invoked raw, but it doesn't change anything, from the makefile, the targets are phony anyways. You are right it's probably due to caching. |
Given the performance regression, is it still worth investigating the difference in the number of tested modules? |
I'm not sure. I'm still very curious to know why the test count doesn't match, this is very bizare. |
I guess, dlang/dmd#15795 would be useful here |
Yes, at least we'll be able to identify what the changes are and if they are bad or not. Ideally, we'd like to runt the tests from the modules we pass explicitly, and only these (that's not at all what dmd/rdmd are doing). |
Hopefully that other PR I made to enable that behaviour can get merged... |
cf07b66
to
39f39ba
Compare
4acd1ab
to
e854d3d
Compare
0896895
to
5a79292
Compare
7ce40a5
to
4dbe602
Compare
Experiment: replace
rdmd
withdmd -run
Opinions?
Please, let me know if I broke something.