Mechanism to track currently-dirtiest region. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsm9000
force-pushed
the
track_dirtiest_region
branch
from
47f5af4 to
8dc7f99
Compare
deadalnix
reviewed
Feb 13, 2024
Comment on lines
+686
to
+689
| freeRun(addresses[0 .. 2]); | ||
| assert(regionAllocator.dirtyBlockCount == 11); | ||
| verifyUniqueRegion(addresses[0], 2, 2, 2); | ||
| verifyDirtiestRegion(addresses[10], 5, 5); |
There was a problem hiding this comment.
Why was the order changed here?
There was a problem hiding this comment.
Moved it so as to test the region at addresses[10] remaining the longest dirty region at the end.
There was a problem hiding this comment.
It needed a case where a region is freed, but the currently-dirtiest region does not change. The re-ordering gives this.
There was a problem hiding this comment.
It's generally better to add new tests cases for what we want to test, as it prove none of the existing things are broken. Nevertheless, I get it now.
That being said, it seems that every single call to verifyUniqueRegion is now followed by a call to verifyDirtiestRegion. Then why have two functions?
deadalnix
force-pushed
the
master
branch
2 times, most recently
from
4acd1ab to
e854d3d
Compare
deadalnix
force-pushed
the
master
branch
3 times, most recently
from
0896895 to
5a79292
Compare
deadalnix
force-pushed
the
master
branch
3 times, most recently
from
7ce40a5 to
4dbe602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of 2 to resolve #270 .