Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flutter 3.24.x #2

Merged
merged 27 commits into from
Dec 18, 2024

Conversation

stevsct
Copy link

@stevsct stevsct commented Dec 10, 2024

No description provided.

NikosTsesmelis and others added 25 commits June 17, 2022 12:21
* Removed dependency on libphonenumber
* Switch from libphonenumber-iOS to PhoneNumberKit on iOS
* Update libphonenumber.js file
* Depreciating getNameForNumber in future updates
* Add safe area boolean to SelectorConfig and use it in bottom sheet show

* Add useBottomSheetSafeArea to example

* Update readme

it would close also 2 issues reported for some time natintosh#285 and natintosh#220
Updated "GB" from "United Kingdom of Great Britain and Northern Irela…
@@ -1,3 +1,9 @@
plugins {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on est obligés de mettre à jour la sample app ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui car les dépendances dont on a besoin ont déjà fait la migration et on a des erreurs de build lorsqu'on tente de lancer l'app

@@ -142,7 +141,7 @@ extension phonenumbertypeproperties on PhoneNumberType {
return 2;
case PhoneNumberType.TOLL_FREE:
return 3;
case PhoneNumberType.PREMIUM_RATE:
case PhoneNumberType.PREMIUM_RATE || PhoneNumberType.PREMIUM_RATE:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PhoneNumberType.PREMIUM_RATE || PhoneNumberType.PREMIUM_RATE

bizarre, non ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrigé

@stevenosse stevenosse merged commit 1439bdf into sncf-connect-tech:develop Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.