332 comsngularkloadgenserializerprotobufserializer nullpointerexception #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a trim statement to avoid problem when cast the schemas from classpath
Removed some unused test files
…rializer-nullpointerexception
Apparently the original project was renamed into cmak to avoid break the TOS of kafka having the kafka in the name of unofficial tool
…genserializerprotobufserializer-nullpointerexception # Conflicts: # pom.xml # src/main/java/com/sngular/kloadgen/sampler/SamplerUtil.java # src/test/resources/mappings/schema_registry_stub.json
2 tasks
dhergonsngular
requested review from
nuriaricofr,
jemacineiras,
5uso-sng,
AdrianLagartera,
alfredo9f,
davidgayoso,
josemenvegsngular and
rabad-sng
davidgayoso
reviewed
Mar 28, 2023
| final var importSchema = JMeterHelper.getParsedSchema(getSubjectName(importedClass, metadata), JMeterContextService.getContext().getProperties()); | ||
| if (!ProtobufHelper.NOT_ACCEPTED_IMPORTS.contains(importedClass)) { | ||
| schemaBuilder.addDependency(((ProtobufSchema) importSchema).toDescriptor().getFullName()); | ||
| schemaBuilder.addSchema(convertDynamicSchema((ProtobufSchema) importSchema)); |
There was a problem hiding this comment.
It is not an error, but I think it would be cleaner to create a variable to hold the value of importSchema because that way you avoid to do the cast several times.
davidgayoso
reviewed
Mar 28, 2023
| @@ -295,7 +326,7 @@ private static void extracted( | |||
| msgDef.addField("repeated", "typemapnumber" + elementField.getName(), elementField.getName(), elementField.getTag()); | |||
|
|
|||
| msgDef.addMessageDefinition( | |||
| MessageDefinition.newBuilder("typemapnumber" + elementField.getName()).addField(OPTIONAL, "string", "key", 1).addField(OPTIONAL, realType, "value", 2).build()); | |||
| MessageDefinition.newBuilder("typemapnumber" + elementField.getName()).addField(OPTIONAL, "string", "key", 1).addField(OPTIONAL, realType, "value", 2).build()); | |||
There was a problem hiding this comment.
You use the value of "typemapnumber" several times, so it would be nice to create a variable with that value.
5uso-sng
reviewed
Mar 28, 2023
src/main/java/com/sngular/kloadgen/processor/util/SchemaProcessorUtils.java
Outdated
Show resolved
Hide resolved
jemacineiras
approved these changes
Mar 28, 2023
jemacineiras
deleted the
332-comsngularkloadgenserializerprotobufserializer-nullpointerexception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf Schemas import fixed