Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplifies attrs support #204

Merged
merged 1 commit into from
Jan 20, 2025
Merged

refactor: Simplifies attrs support #204

merged 1 commit into from
Jan 20, 2025

Conversation

Daverball
Copy link
Collaborator

Gets rid of some complex code we no longer need, since lookup_full_name already gives us what we want.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.4%. Comparing base (04d1a05) to head (e657d28).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #204   +/-   ##
=====================================
  Coverage   96.4%   96.4%           
=====================================
  Files          4       4           
  Lines        987     959   -28     
=====================================
- Hits         952     925   -27     
+ Misses        35      34    -1     
Files with missing lines Coverage Δ
flake8_type_checking/checker.py 96.1% <100.0%> (-0.1%) ⬇️
flake8_type_checking/constants.py 100.0% <ø> (ø)

@Daverball Daverball merged commit 7d24f79 into main Jan 20, 2025
7 checks passed
@Daverball Daverball deleted the refactor/attrs branch January 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant