Skip to content

Commit

Permalink
SNOW-1833578 support for .net9 (#1065)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-knozderko authored Dec 4, 2024
1 parent f02a633 commit 4c44f1f
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['net6.0', 'net7.0', 'net8.0', 'net462', 'net471', 'net472', 'net48', 'net481']
dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0', 'net462', 'net471', 'net472', 'net48', 'net481']
cloud_env: ['AZURE', 'GCP', 'AWS']
steps:
- name: Checkout code
Expand All @@ -42,6 +42,7 @@ jobs:
dotnet-version: |
6.0.x
8.0.x
9.0.x
dotnet-quality: 'ga'
- name: Setup Python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -93,7 +94,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['net6.0', 'net7.0', 'net8.0']
dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0']
cloud_env: ['AZURE', 'GCP', 'AWS']
steps:
- uses: actions/checkout@v4
Expand All @@ -103,6 +104,7 @@ jobs:
dotnet-version: |
6.0.x
8.0.x
9.0.x
dotnet-quality: 'ga'
- name: Setup Python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -152,7 +154,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['net6.0', 'net7.0', 'net8.0']
dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0']
cloud_env: ['AZURE', 'GCP', 'AWS']
steps:
- uses: actions/checkout@v4
Expand All @@ -162,6 +164,7 @@ jobs:
dotnet-version: |
6.0.x
8.0.x
9.0.x
dotnet-quality: 'ga'
- name: Setup Python
uses: actions/setup-python@v5
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[![NuGet](https://img.shields.io/nuget/v/Snowflake.Data.svg)](https://www.nuget.org/packages/Snowflake.Data/)
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)

The Snowflake .NET connector supports the the following .NET framework and libraries versions:
The Snowflake .NET connector supports the following .NET framework and libraries versions:

- .NET Framework 4.6.2
- .NET Framework 4.7.1
Expand All @@ -14,6 +14,7 @@ The Snowflake .NET connector supports the the following .NET framework and libra
- .NET 6.0
- .NET 7.0
- .NET 8.0
- .NET 9.0

Disclaimer: While the connector targets netstandard2.0 and may work with versions in its [support matrix](https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#select-net-standard-version), only the versions listed above are supported and tested by the connector

Expand Down
4 changes: 2 additions & 2 deletions Snowflake.Data.Tests/Snowflake.Data.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;net8.0;net462;net471;net472;net48;net481</TargetFrameworks>
<TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0;net7.0;net8.0;</TargetFrameworks>
<TargetFrameworks>net6.0;net7.0;net8.0;net9.0;net462;net471;net472;net48;net481</TargetFrameworks>
<TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
<Title>Snowflake.Data.Tests</Title>
<Description>Snowflake Connector for .NET</Description>
<Company>Snowflake Computing, Inc</Company>
Expand Down
2 changes: 2 additions & 0 deletions Snowflake.Data.Tests/UnitTests/SFEnvironmentTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ public void TestRuntimeExtraction()
expectedVersion = "7.0";
#elif NET8_0
expectedVersion = "8.0";
#elif NET9_0
expectedVersion = "9.0";
#endif

// Act
Expand Down

0 comments on commit 4c44f1f

Please sign in to comment.