Skip to content

Commit

Permalink
fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-knozderko committed Nov 28, 2024
1 parent 7ae1104 commit ded25c2
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 8 deletions.
12 changes: 8 additions & 4 deletions Snowflake.Data.Tests/UnitTests/PutGetStageInfoTest.cs
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/*
* Copyright (c) 2024 Snowflake Computing Inc. All rights reserved.
*/

using System.Collections.Generic;
using NUnit.Framework;
using Snowflake.Data.Core;
Expand All @@ -10,16 +14,16 @@ public class PutGetStageInfoTest
{
[Test]
[TestCaseSource(nameof(TestCases))]
public void TestGcmRegionalUrl(string region, bool useRegionalUrl, string endPoint, string expectedGcmEndpoint)
public void TestGcsRegionalUrl(string region, bool useRegionalUrl, string endPoint, string expectedGcsEndpoint)
{
// arrange
var stageInfo = CreateGCSStageInfo(region, useRegionalUrl, endPoint);
var stageInfo = CreateGcsStageInfo(region, useRegionalUrl, endPoint);

// act
var gcsCustomEndpoint = stageInfo.GcsCustomEndpoint();

// assert
Assert.AreEqual(expectedGcmEndpoint, gcsCustomEndpoint);
Assert.AreEqual(expectedGcsEndpoint, gcsCustomEndpoint);
}

internal static IEnumerable<object[]> TestCases()
Expand All @@ -41,7 +45,7 @@ internal static IEnumerable<object[]> TestCases()
yield return new object[] { "US-CENTRAL1", true, "example.com", "example.com" };
}

private PutGetStageInfo CreateGCSStageInfo(string region, bool useRegionalUrl, string endPoint) =>
private PutGetStageInfo CreateGcsStageInfo(string region, bool useRegionalUrl, string endPoint) =>
new PutGetStageInfo
{
locationType = SFRemoteStorageUtil.GCS_FS,
Expand Down
2 changes: 1 addition & 1 deletion Snowflake.Data.Tests/UnitTests/SFGCSClientTest.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012-2023 Snowflake Computing Inc. All rights reserved.
* Copyright (c) 2012-2024 Snowflake Computing Inc. All rights reserved.
*/

using System;
Expand Down
6 changes: 3 additions & 3 deletions Snowflake.Data/Core/FileTransfer/StorageClient/SFGCSClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ public SFGCSClient(PutGetStageInfo stageInfo)

private Google.Cloud.Storage.V1.StorageClient BuildStorageClient(StorageClientBuilder builder, PutGetStageInfo stageInfo)
{
var gcmCustomEndpoint = stageInfo.GcsCustomEndpoint();
if (!string.IsNullOrEmpty(gcmCustomEndpoint))
builder.BaseUri = gcmCustomEndpoint;
var gcsCustomEndpoint = stageInfo.GcsCustomEndpoint();
if (!string.IsNullOrEmpty(gcsCustomEndpoint))
builder.BaseUri = gcsCustomEndpoint;
return builder.Build();
}

Expand Down

0 comments on commit ded25c2

Please sign in to comment.