Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1640968 Dispose http response in Okta Authenticator #1010

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Aug 28, 2024

Description

SNOW-1640968 Dispose http response in Okta Authenticator

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner August 28, 2024 10:26
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.62%. Comparing base (adac81a) to head (a283178).

Files Patch % Lines
...flake.Data/Core/Authenticator/OktaAuthenticator.cs 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
- Coverage   85.63%   85.62%   -0.01%     
==========================================
  Files         106      106              
  Lines       10788    10796       +8     
  Branches     1033     1035       +2     
==========================================
+ Hits         9238     9244       +6     
  Misses       1303     1303              
- Partials      247      249       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko enabled auto-merge (squash) August 28, 2024 13:55
@sfc-gh-knozderko sfc-gh-knozderko merged commit 60c2f2b into master Aug 28, 2024
53 of 54 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1640968_dispose_http_response branch August 28, 2024 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants