Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1502317: Stop retry on nonrecoverable exception #1013

Merged

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Stop retry on nonrecoverable exception

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (caace83) to head (c4b9781).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   85.64%   85.69%   +0.04%     
==========================================
  Files         117      117              
  Lines       11331    11352      +21     
  Branches     1130     1133       +3     
==========================================
+ Hits         9705     9728      +23     
+ Misses       1346     1344       -2     
  Partials      280      280              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Snowflake.Data/Core/HttpUtil.cs Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf force-pushed the SNOW-1502317-Nonrecoverable-Http-Exceptions branch from c3e6a0c to c4b9781 Compare September 18, 2024 19:49
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit aef4d3a into master Sep 18, 2024
53 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-1502317-Nonrecoverable-Http-Exceptions branch September 18, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants