Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1616044 set DateTimeKind.Unspecified for TIMESTAMP_NTZ, TIME and DATE #1033

Merged
merged 6 commits into from
Oct 8, 2024
Merged

SNOW-1616044 set DateTimeKind.Unspecified for TIMESTAMP_NTZ, TIME and DATE #1033

merged 6 commits into from
Oct 8, 2024

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak commented Oct 1, 2024 •
edited
Loading

Set DateTimeKind.Unspecified for TIMESTAMP_NTZ, TIME and DATE including structured types and ARROW/JSON format

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.88%. Comparing base (717a804) to head (041ee93).

Files with missing lines Patch % Lines
Snowflake.Data/Core/Converter/TimeConverter.cs 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
+ Coverage   85.79%   85.88%   +0.09%     
==========================================
  Files         118      118              
  Lines       11451    11456       +5     
  Branches     1146     1146              
==========================================
+ Hits         9824     9839      +15     
+ Misses       1343     1334       -9     
+ Partials      284      283       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dstempniak sfc-gh-dstempniak marked this pull request as ready for review October 2, 2024 07:22
@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner October 2, 2024 07:22
@sfc-gh-dstempniak sfc-gh-dstempniak changed the title SNOW-1616044 set DateTimeKind.Unspecified for TIMESTAMP_NTZ and TIME SNOW-1616044 set DateTimeKind.Unspecified for TIMESTAMP_NTZ, TIME and DATE Oct 4, 2024
sfc-gh-pbulawa
sfc-gh-pbulawa approved these changes Oct 8, 2024
View reviewed changes
Snowflake.Data/Core/ArrowResultChunk.cs Outdated Show resolved Hide resolved
@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 3d0194c into master Oct 8, 2024
54 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1616044_fix_date_kind branch October 8, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dstempniak @sfc-gh-pbulawa @sfc-gh-knozderko