Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1729244 support for large and small timestamps #1038

Merged
merged 9 commits into from
Oct 21, 2024

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak commented Oct 9, 2024

Description

Support for large and small timestamps such as 0001-01-01 and 9999-12-31.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.97%. Comparing base (b146410) to head (69d4819).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
+ Coverage   85.84%   85.97%   +0.12%     
==========================================
  Files         118      118              
  Lines       11482    11493      +11     
  Branches     1148     1152       +4     
==========================================
+ Hits         9857     9881      +24     
+ Misses       1341     1333       -8     
+ Partials      284      279       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dstempniak sfc-gh-dstempniak marked this pull request as ready for review October 10, 2024 09:31
@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner October 10, 2024 09:31
@sfc-gh-dstempniak sfc-gh-dstempniak changed the title SNOW-1729244 support for large timestamps SNOW-1729244 support for large and small timestamps Oct 10, 2024
Snowflake.Data/Core/SFBindUploader.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/SFBindUploader.cs Show resolved Hide resolved
Snowflake.Data/Core/SFBindUploader.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/SFDataConverter.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/SFDataConverterTest.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides this one what sfc-gh-knozderko found looks legit

@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 90b7007 into master Oct 21, 2024
52 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1729244_large_timestaps branch October 21, 2024 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants