Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1524245 Gcm encryption using BouncyCastle #1043

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1524245 Gcm encryption using BouncyCastle

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner October 21, 2024 14:10
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 95.76271% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.15%. Comparing base (f995ba6) to head (e6bf433).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ke.Data/Core/FileTransfer/GcmEncryptionProvider.cs 95.53% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
+ Coverage   85.99%   86.15%   +0.15%     
==========================================
  Files         118      120       +2     
  Lines       11512    11627     +115     
  Branches     1157     1165       +8     
==========================================
+ Hits         9900    10017     +117     
+ Misses       1332     1329       -3     
- Partials      280      281       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 6b1114a into master Oct 25, 2024
54 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1524245_gcm_encryption branch October 25, 2024 11:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants