Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1758373 Documentation for package signature verification #1049

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Oct 28, 2024

Description

SNOW-1758373 Documentation for package signature verification.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner October 28, 2024 13:33
@sfc-gh-knozderko sfc-gh-knozderko changed the title Documentation for package signature verification SNOW-1758373 Documentation for package signature verification Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (8199563) to head (258fcf6).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
- Coverage   86.14%   86.14%   -0.01%     
==========================================
  Files         120      120              
  Lines       11627    11648      +21     
  Branches     1165     1174       +9     
==========================================
+ Hits        10016    10034      +18     
- Misses       1328     1332       +4     
+ Partials      283      282       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sfc-gh-anavalos sfc-gh-anavalos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - names and information looks good. However need to confirm with the next release. Names may be renamed when uploaded to the release tag, for example https://github.com/snowflakedb/snowflake-connector-python/releases/tag/v3.12.3, the word resources. was added at the beginning of the file name.

@sfc-gh-knozderko sfc-gh-knozderko enabled auto-merge (squash) November 5, 2024 18:10
@sfc-gh-knozderko sfc-gh-knozderko merged commit 4392447 into master Nov 5, 2024
47 of 50 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the package_signature_doc branch November 5, 2024 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants