Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1833578 support for .net9 #1065

Merged
merged 6 commits into from
Dec 4, 2024
Merged

SNOW-1833578 support for .net9 #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7de39c6
SNOW-1833578 support for .net9
sfc-gh-knozderko Nov 28, 2024
94f54f4
add net9 to tests
sfc-gh-knozderko Nov 28, 2024
122c44d
fix test
sfc-gh-knozderko Nov 28, 2024
bc6a58b
Merge branch 'master' into SNOW-1833578_support_net9
sfc-gh-knozderko Nov 29, 2024
b34e2b3
add missing target
sfc-gh-knozderko Nov 29, 2024
d1997f5
Merge branch 'master' into SNOW-1833578_support_net9
sfc-gh-knozderko Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['net6.0', 'net7.0', 'net8.0', 'net462', 'net471', 'net472', 'net48', 'net481']
dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0', 'net462', 'net471', 'net472', 'net48', 'net481']
cloud_env: ['AZURE', 'GCP', 'AWS']
steps:
- name: Checkout code
Expand All @@ -42,6 +42,7 @@ jobs:
dotnet-version: |
6.0.x
8.0.x
9.0.x
dotnet-quality: 'ga'
- name: Setup Python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -93,7 +94,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['net6.0', 'net7.0', 'net8.0']
dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0']
cloud_env: ['AZURE', 'GCP', 'AWS']
steps:
- uses: actions/checkout@v4
Expand All @@ -103,6 +104,7 @@ jobs:
dotnet-version: |
6.0.x
8.0.x
9.0.x
dotnet-quality: 'ga'
- name: Setup Python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -152,7 +154,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dotnet: ['net6.0', 'net7.0', 'net8.0']
dotnet: ['net6.0', 'net7.0', 'net8.0', 'net9.0']
cloud_env: ['AZURE', 'GCP', 'AWS']
steps:
- uses: actions/checkout@v4
Expand All @@ -162,6 +164,7 @@ jobs:
dotnet-version: |
6.0.x
8.0.x
9.0.x
dotnet-quality: 'ga'
- name: Setup Python
uses: actions/setup-python@v5
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[![NuGet](https://img.shields.io/nuget/v/Snowflake.Data.svg)](https://www.nuget.org/packages/Snowflake.Data/)
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)

The Snowflake .NET connector supports the the following .NET framework and libraries versions:
The Snowflake .NET connector supports the following .NET framework and libraries versions:

- .NET Framework 4.6.2
- .NET Framework 4.7.1
Expand All @@ -14,6 +14,7 @@ The Snowflake .NET connector supports the the following .NET framework and libra
- .NET 6.0
- .NET 7.0
- .NET 8.0
- .NET 9.0

Disclaimer: While the connector targets netstandard2.0 and may work with versions in its [support matrix](https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#select-net-standard-version), only the versions listed above are supported and tested by the connector

Expand Down
4 changes: 2 additions & 2 deletions Snowflake.Data.Tests/Snowflake.Data.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;net8.0;net462;net471;net472;net48;net481</TargetFrameworks>
<TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0;net7.0;net8.0;</TargetFrameworks>
<TargetFrameworks>net6.0;net7.0;net8.0;net9.0;net462;net471;net472;net48;net481</TargetFrameworks>
<TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
<Title>Snowflake.Data.Tests</Title>
<Description>Snowflake Connector for .NET</Description>
<Company>Snowflake Computing, Inc</Company>
Expand Down
2 changes: 2 additions & 0 deletions Snowflake.Data.Tests/UnitTests/SFEnvironmentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ public void TestRuntimeExtraction()
expectedVersion = "7.0";
#elif NET8_0
expectedVersion = "8.0";
#elif NET9_0
expectedVersion = "9.0";
#endif

// Act
Expand Down
Loading