-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1731124 Arrow batches fields #1925
Open
sfc-gh-astachowski
wants to merge
41
commits into
SNOW-873466-arrow-batches
Choose a base branch
from
arrow-batches-fields
base: SNOW-873466-arrow-batches
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+305
−28
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
4d64dab
Initial version
sfc-gh-astachowski 986967d
Initial tests
sfc-gh-astachowski c9f6287
Formatting
sfc-gh-astachowski 0fc7b5a
Import formatting
sfc-gh-astachowski b409510
Added missing interface definitions
sfc-gh-astachowski 1de2c39
Implemented review feedback
sfc-gh-astachowski 969c59c
Further review feedback
sfc-gh-astachowski f12fdeb
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-all-simpl…
sfc-gh-astachowski a1cfe08
Added handling of remaining types
sfc-gh-astachowski 53638df
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-all-simpl…
sfc-gh-astachowski 0fd7d0f
Add null time zone check
sfc-gh-astachowski 73d6b4d
Removed timestamp support
sfc-gh-astachowski 7424acf
Added timestamp support
sfc-gh-astachowski 3dd20a9
Formatting
sfc-gh-astachowski 28fb57a
Removed old comments
sfc-gh-astachowski afa1142
Fixed memory leak and added assertion of no leaks in tests.
sfc-gh-astachowski 7c9ab7a
Fixed memory leaks and added assertions of no memory leaks.
sfc-gh-astachowski 31bb11b
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-all-simpl…
sfc-gh-astachowski ec255ee
Merge branch 'arrow-batches-all-simple-types' into arrow-batches-time…
sfc-gh-astachowski 69cfe59
Merge fixes
sfc-gh-astachowski e26e56c
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-all-simpl…
sfc-gh-astachowski 1c34bb9
Added null check
sfc-gh-astachowski de52645
Merge branch 'arrow-batches-all-simple-types' into arrow-batches-time…
sfc-gh-astachowski ef5238c
Formatting
sfc-gh-astachowski f4ace2d
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-all-simpl…
sfc-gh-astachowski 660c0de
Merge branch 'arrow-batches-all-simple-types' into arrow-batches-time…
sfc-gh-astachowski 45de13f
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-all-simpl…
sfc-gh-astachowski 44e608d
Merge fixes
sfc-gh-astachowski 400fd13
Added try-with-resources statements
sfc-gh-astachowski 56eb83e
Merge branch 'arrow-batches-all-simple-types' into arrow-batches-time…
sfc-gh-astachowski 318bc4f
Merge fixes and introduced constants
sfc-gh-astachowski c5af779
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-timestamps
sfc-gh-astachowski 82a68b7
Added closing vector in finally block and try-with-resources
sfc-gh-astachowski 5cd55a7
Added extra tests and related fixes
sfc-gh-astachowski 23b79d3
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-timestamps
sfc-gh-astachowski 52e641d
Added proper field handling
sfc-gh-astachowski 66f4bc7
Merge branch 'SNOW-873466-arrow-batches' into arrow-batches-fields
sfc-gh-astachowski 113ffc2
Added FieldType to VarCharVector init
sfc-gh-astachowski 245d420
Added a test for correct field types in map conversion
sfc-gh-astachowski 39ecf66
Fix offset buffer issue in ListConverter
sfc-gh-astachowski c55f461
Formatting
sfc-gh-astachowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the line that required the whole change - if we don't keep nullability properly, mapVector will complain about it's grandchildren being nullable. As the grandchildren may be of any type, all converters were affected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add some tests to show the improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a unit test checking if FieldTypes behave as expected when converting a MapVector