Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user_id from dimension and add it as "metric" in ad views #81

Merged

Conversation

ilias1111
Copy link
Contributor

Description & motivation

In essence we are going to treat user_id the same way we treat domain_sessionid_array, as we may have more than one value and this will cause unwanted extra rows.

This could be happening in cases were we have anonmazion on for media package, we dont capture the user id until the user accepts the tracking and then for the same session, ad_id etc we will have 2 ids null and the real one.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have raised a documentation PR if applicable (Link here)

In essence we are going to treat user_id the same way we treat domain_sessionid_array, as we may have more than one value and this will cause unwanted extra rows.
@ilias1111 ilias1111 marked this pull request as ready for review October 22, 2024 10:27
@ilias1111 ilias1111 requested a review from a team as a code owner October 22, 2024 10:27
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure if it's a breaking change? The schema of the table does not change, just that historical data could be processed differently now. Not sure if that is considered breaking though.

@ilias1111
Copy link
Contributor Author

@agnessnowplow Should we call it a breaking change? Assuming we dont have reports of users having issue with all that, we could expect I guess that we didnt had lot of cases that will be reprocced differently

@agnessnowplow
Copy link
Contributor

I would say the only time past records would be different is if there were duplicates, but it would have resulted in an error right away (we also have a dbt test on uniqueness) so I don't consider this a breaking change.

@ilias1111 ilias1111 merged commit 4c01c52 into Release-snowplow-media-player/0.9.1 Oct 23, 2024
6 checks passed
ilias1111 added a commit that referenced this pull request Oct 23, 2024
In essence we are going to treat user_id the same way we treat domain_sessionid_array, as we may have more than one value and this will cause unwanted extra rows.
ilias1111 added a commit that referenced this pull request Oct 23, 2024
In essence we are going to treat user_id the same way we treat domain_sessionid_array, as we may have more than one value and this will cause unwanted extra rows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants