Add dev.amp.snowplow/amp_session/jsonschema/1-0-0 (closes #1234) #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could go for Max Safe Integer |
igneel64
force-pushed
the
feature/1234-add_amp_session_schema
branch
from
510f1e4 to
bf7da4d
Compare
|
Added max safe integer! |
paulboocock
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
LGTM. This can be merged into a release/r137 branch (you might need to create it) and the typically Prepare for release commit should also be added (with changelog updates and such) e.g. 2ec9d57
Once thats done, then should be able to release this. I don't imagine other schemas will be ready particularly soon so might aswell get this out now, then we can do a r138 once the other new tracking ones are ready.
|
Merged at #1238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the amp_session schema.
sessionCreationTimestampandlastSessionEventTimestampare sending values of 'milliseconds since Epoch' as you would get the result from calling in the browsernew Date().getTime(). What would we set as the expected maximum of this value ? For now I have set the maximum asmaximum of seconds since Epoch * 1000See more at snowplow-incubator/amphtml#20