Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/4.3.1 #1406

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Release/4.3.1 #1406

merged 2 commits into from
Jan 21, 2025

Conversation

matus-tomlein
Copy link
Contributor

Bug fixes:

  • Update WebView tracker version WebView plugin to fix issue with tracking page view and page ping event properties

Copy link

bundlemon bot commented Jan 20, 2025

BundleMon

Files added (6)
Status Path Size Limits
trackers/javascript-tracker/dist/sp.js
+24.54KB 30KB / +10%
libraries/browser-tracker-core/dist/index.mod
ule.js
+23.59KB 25KB / +10%
libraries/tracker-core/dist/index.module.js
+19.5KB 20KB / +10%
trackers/browser-tracker/dist/index.umd.min.j
s
+17.44KB 20KB / +10%
trackers/javascript-tracker/dist/sp.lite.js
+17.39KB 20KB / +10%
trackers/browser-tracker/dist/index.module.js
+3.49KB 5KB / +10%

Total files change +105.95KB 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link
Contributor

@mscwilson mscwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

"changes": [
{
"packageName": "@snowplow/browser-plugin-webview",
"comment": "Update WebView tracker version WebView plugin to fix issue with tracking page view and page ping event properties",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"comment": "Update WebView tracker version WebView plugin to fix issue with tracking page view and page ping event properties",
"comment": "Update WebView tracker version and WebView plugin to fix issue with tracking page view and page ping event properties",

@matus-tomlein matus-tomlein merged commit 1f0ff3b into master Jan 21, 2025
3 checks passed
@matus-tomlein matus-tomlein deleted the release/4.3.1 branch January 21, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants