Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ecommerce Events (close #329) #330

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jack-Keene
Copy link
Contributor

No description provided.

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Apr 3, 2023
@Jack-Keene Jack-Keene changed the base branch from master to release/0.15.0 April 3, 2023 16:32
@Jack-Keene Jack-Keene marked this pull request as ready for review April 3, 2023 16:47
@Jack-Keene Jack-Keene requested a review from matus-tomlein April 3, 2023 16:47
@Jack-Keene Jack-Keene changed the title Deprecate Ecommerce Events (close #329) Remove Ecommerce Events (close #329) Apr 4, 2023
@Jack-Keene Jack-Keene changed the base branch from release/0.15.0 to release/1.0.0 April 19, 2023 17:17
@matus-tomlein
Copy link
Contributor

I am a bit unsure whether we can already remove the old ecommerce events. It might be better for two things to happen (or at least one of them):

  1. We update the currency conversion enrichment to work with the new Snowplow ecommerce events.
  2. We implement APIs for the new Snowplow ecommerce events in the Python tracker.

Otherwise we are removing functionality without providing an alternative which makes me a bit nervous. So I would suggest keeping this PR open for maybe v2 of the tracker? But happy to discuss if there are other opinions.

@Jack-Keene
Copy link
Contributor Author

I wasn't initially aware the ecom events were linked to the currency enrichment, so this makes sense.

In the JS tracker I think we added an enhanced ecom API, could we do something similar for Python, and add a line in the ecom event deprecation notices to use the enhanced events?

@matus-tomlein
Copy link
Contributor

The enhanced ecommerce is already outdated, but we have the recent Snowplow Ecommerce that is a new plugin in the JS tracker (also in an accelerator) which we could also add here. We are currently adding it to the mobile trackers. Would be nice to have it everywhere but I think it's a larger task that needs some planning.

Base automatically changed from release/1.0.0 to master June 16, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants