Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat / Display username of reaction maker in ViewReaction BottomSheet #111

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Feat / Display username of reaction maker in ViewReaction BottomSheet #111

merged 1 commit into from
Dec 7, 2023

Conversation

dawitfamanu
Copy link
Contributor

Changes:

  • Display username of reaction maker in ViewReaction Bottomsheet
  • Highlight in yellow if reaction was added by current user

image

Notes:
For now, I added a new EmojiCell composable specifically for this case. After UAT, CustomBottomSheet should be refactored (assignee: Dawit)

thisisWooyeol
thisisWooyeol approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@thisisWooyeol thisisWooyeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. post fetch등의 동기화는 추후 수정하는 것으로 하겠습니다.

@thisisWooyeol thisisWooyeol merged commit c382d18 into develop Dec 7, 2023
2 checks passed
@thisisWooyeol thisisWooyeol deleted the feat/android-Reaction-EmojiCell branch December 7, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisWooyeol thisisWooyeol thisisWooyeol approved these changes

@peng-u-0807 peng-u-0807 Awaiting requested review from peng-u-0807

@2018JunyoungLim 2018JunyoungLim Awaiting requested review from 2018JunyoungLim

@yangchanhk98 yangchanhk98 Awaiting requested review from yangchanhk98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawitfamanu @thisisWooyeol