Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Show error dialog when there is no internet connection #112

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Fix: Show error dialog when there is no internet connection #112

merged 6 commits into from
Dec 7, 2023

Conversation

thisisWooyeol
Copy link
Contributor

수정사항

  • 기존 EmojiRepository에서 video thumbnail을 제작하는 메소드를 EmojiDataSource 클래스의 메소드가 되도록 수정했습니다
  • Repository level에서는 api response를 받아오고 UseCase level에서 exception을 처리하도록 통일했습니다
  • Internet connection이 없을 시 (java.net.ConnectionException) 아래와 같은 네트워크 접속 오류 dialog가 뜨도록 수정했습니다

고민

  • fetchEmoji, fetchPost에도 dialog를 띄우는 게 맞을지 고민. 보통 소셜미디어 앱에서 fetch시 네크워크가 없을 경우 dialog를 안 띄우는 것 같아서 추후 수정이 필요할 수도 있습니다.
    Screenshot_20231207_131631_EmojiHub

dawitfamanu
dawitfamanu approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@dawitfamanu dawitfamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@dawitfamanu dawitfamanu merged commit 16c74c8 into develop Dec 7, 2023
2 checks passed
@thisisWooyeol thisisWooyeol deleted the fix/network-timeout-handling branch December 7, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawitfamanu dawitfamanu dawitfamanu approved these changes

@peng-u-0807 peng-u-0807 Awaiting requested review from peng-u-0807

@2018JunyoungLim 2018JunyoungLim Awaiting requested review from 2018JunyoungLim

@yangchanhk98 yangchanhk98 Awaiting requested review from yangchanhk98

Assignees

@peng-u-0807 peng-u-0807

@thisisWooyeol thisisWooyeol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisWooyeol @dawitfamanu @peng-u-0807