Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3 preview emoji update on uploading reaction #114

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix 3 preview emoji update on uploading reaction #114

merged 2 commits into from
Dec 7, 2023

Conversation

thisisWooyeol
Copy link
Contributor

수정사항

  • 이모지를 업로드하자마자 포스트의 이모지가 업데이트되도록 수정했습니다.
  • 불필요한 api call을 줄이기 위해 mySavedEmoji, myCreatedEmoji fetch call의 launched effect 조건을 분리했습니다

dawitfamanu
dawitfamanu approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@dawitfamanu dawitfamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@dawitfamanu dawitfamanu merged commit 6831a3a into develop Dec 7, 2023
2 checks passed
@thisisWooyeol thisisWooyeol deleted the fix/feed-3-emoji-update branch December 7, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawitfamanu dawitfamanu dawitfamanu approved these changes

@peng-u-0807 peng-u-0807 Awaiting requested review from peng-u-0807

@2018JunyoungLim 2018JunyoungLim Awaiting requested review from 2018JunyoungLim

@yangchanhk98 yangchanhk98 Awaiting requested review from yangchanhk98

Assignees

@peng-u-0807 peng-u-0807

@thisisWooyeol thisisWooyeol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisWooyeol @dawitfamanu @peng-u-0807