Fix network exception uat upload emoji #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisWooyeol
requested review from
dawitfamanu,
peng-u-0807,
2018JunyoungLim and
yangchanhk98
peng-u-0807
reviewed
Dec 7, 2023
| if (currentUserDetails.savedEmojiList?.contains(currentEmoji.id) == true) | ||
| return true | ||
| return false | ||
| return currentUserDetails.savedEmojiList?.contains(currentEmoji.id) == true |
There was a problem hiding this comment.
여기 == true는 빼도 되지 않을까요?
There was a problem hiding this comment.
@peng-u-0807 savedEmojiList 자체가 null일 수 있어서 == true 를 추가해주었습니다!
There was a problem hiding this comment.
@thisisWooyeol 안 그래도 제가 바로 앞 pr(#121 )에서 savedEmojiList를 빈 리스트로 초기화해서 아마 back에서 받을 때 아예 null이지는 않을 겁니다!
There was a problem hiding this comment.
@yangchanhk98 그럼 savedEmojiList, createdEmojiList, createdPostList 전부 non-null 로 바꾸겠습니다!
…t of UserDetailsDto -> non-null
peng-u-0807
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정사항
Network 연결이 없을 시 이모지 upload에서 IOException이 먼저 불려 ConnectionException catch (error dialog 표시)가 수행되지 않는 이슈를 해결했습니다.