Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/back builder #125

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Feat/back builder #125

merged 6 commits into from
Dec 8, 2023

Conversation

yangchanhk98
Copy link
Contributor

수정사항

  • test db를 test 시작 전에 initialize 하는 코드 작성
  • userDto의 created_emojis, saved_emojis, created_posts non-nullable로 변경
  • IdGenerator에서 emoji, post, reaction 의 id 생성 함수 구현
  • 각 Dto class에 builder pattern 적용

@yangchanhk98 yangchanhk98 self-assigned this Dec 7, 2023
thisisWooyeol
thisisWooyeol approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@thisisWooyeol thisisWooyeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@thisisWooyeol thisisWooyeol merged commit 1b0c8dc into develop Dec 8, 2023
3 of 4 checks passed
@thisisWooyeol thisisWooyeol deleted the feat/back-builder branch December 8, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisWooyeol thisisWooyeol thisisWooyeol approved these changes

@dawitfamanu dawitfamanu Awaiting requested review from dawitfamanu

@peng-u-0807 peng-u-0807 Awaiting requested review from peng-u-0807

@2018JunyoungLim 2018JunyoungLim Awaiting requested review from 2018JunyoungLim

Assignees

@yangchanhk98 yangchanhk98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangchanhk98 @thisisWooyeol