Apply suggestions from code review

Co-authored-by: 이석찬 / Lee Sukchan <[email protected]>
snuhcs-course · Oct 25, 2023 · f2c0aeb · f2c0aeb
1 parent f947058
commit f2c0aeb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/frontend/app/src/main/java/com/example/speechbuddy/compose/signup/SignupScreen.kt b/frontend/app/src/main/java/com/example/speechbuddy/compose/signup/SignupScreen.kt
@@ -118,7 +118,7 @@ fun SignupScreen(
                 ButtonUi(
                     text = stringResource(id = R.string.signup),
                     onClick = {
-                        viewModel.signUp()
+                        viewModel.signup(email)
                     },
                 )
             }

diff --git a/frontend/app/src/main/java/com/example/speechbuddy/viewmodel/SignupViewModel.kt b/frontend/app/src/main/java/com/example/speechbuddy/viewmodel/SignupViewModel.kt
@@ -32,9 +32,6 @@ class SignupViewModel @Inject internal constructor(
     private val _uiState = MutableStateFlow(SignupUiState())
     val uiState: StateFlow<SignupUiState> = _uiState.asStateFlow()
 
-    var emailInput by mutableStateOf("")
-        private set
-
     var nicknameInput by mutableStateOf("")
         private set
 
@@ -103,7 +100,7 @@ class SignupViewModel @Inject internal constructor(
         passwordCheckInput = ""
     }
 
-    fun signUp() {
+    fun signup(emailInput: String) {
         if (nicknameInput.isBlank() || nicknameInput.length > Constants.MAXIMUM_NICKNAME_LENGTH) { // Check nickname
             _uiState.update { currentState ->
                 currentState.copy(