Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote Source 테스트 #101

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Remote Source 테스트 #101

merged 4 commits into from
Dec 7, 2023

Conversation

yjeong-k
Copy link
Contributor

@yjeong-k yjeong-k commented Dec 4, 2023 •
edited by JH747
Loading

PR Title: Remote Source 테스트 구현

Related Issue(s):

PR Description:

Remote Source 4개에 대한 테스트를 구현하였습니다.
coverage는 다음과 같습니다.
스크린샷 2023-12-04 오전 9 09 06

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

@yjeong-k yjeong-k added frontend Feature implementation for frontend test labels Dec 4, 2023
JH747
JH747 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@JH747 JH747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test 모두 pass하고 coverage도 잘 되어있습니다.
고생하셨습니다.

@JH747 JH747 merged commit c5e9643 into main Dec 7, 2023
1 check passed
@JH747 JH747 deleted the test/remote-sources branch December 7, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JH747 JH747 JH747 approved these changes

Assignees

@yjeong-k yjeong-k

@sukchan-0811 sukchan-0811

Labels
frontend Feature implementation for frontend test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjeong-k @JH747 @sukchan-0811