Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managers 테스트 구현 #102

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Managers 테스트 구현 #102

merged 4 commits into from
Dec 7, 2023

Conversation

yjeong-k
Copy link
Contributor

@yjeong-k yjeong-k commented Dec 5, 2023

PR Title: Managers 테스트 구현

Related Issue(s):

DAO 테스트 작성하신 것 참고하여, Context를 사용하는 SettingsPrefsManager, AuthTokenPrefsManager, UserIdPrefsManager는 Test가 아닌 androidTest에 작성하였습니다..!

PR Description:

4가지 managers에 대한 테스트를 구현하였습니다.
상기한 세 가지 manager 외, SessionManager의 coverage는 다음과 같습니다.
스크린샷 2023-12-05 오후 7 25 28

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@yjeong-k yjeong-k added frontend Feature implementation for frontend test labels Dec 5, 2023
@yjeong-k yjeong-k requested a review from JH747 December 5, 2023 10:26
Copy link
Contributor

@JH747 JH747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 모두 pass하고 있고 SessionManager의 coverage도 좋습니다.
고생하셨습니다.

@JH747 JH747 merged commit 070ca99 into main Dec 7, 2023
1 check passed
@JH747 JH747 deleted the test/managers branch December 7, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Feature implementation for frontend test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants