Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix db init, auto login, guest mode, backup, coroutine, etc. #107

Merged
merged 9 commits into from
Dec 9, 2023

Conversation

sukchan-0811
Copy link
Contributor

PR Title: Fix db init, auto login, guest mode, backup, coroutine, etc.

Related Issue(s):

Link or reference any related issues or tickets.

PR Description:

DB 초기화, 자동 로그인, 게스트 모드, 백업, 코루틴 관련 버그를 수정하고 코드를 개선했습니다.

이제 앱 시작 시 동작은 다음과 같습니다.

  1. 앱 내에 자동 로그인 해줘야 하는 유저 관련 데이터가 있는지 확인 (GUEST_ID 포함)
  2. 그러한 데이터가 있을 경우, sessionManager에 우선 authToken 먼저 저장 (백업할 때 필요)
  3. (2에서 이어짐) 백업 진행 후, 자동 로그인 처리 (sessionManager에 userId 저장) -> HomeActivity로 이동
  4. 그러한 데이터가 없을 경우, DB 초기화 (weight table, symbol/category DAO)

중요한 코드 변경 사항은 AuthActivity, SessionManager, AuthRepository, UserRepository, AccountSettingsViewModel, SeedDatabaseWorker에 있습니다.

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@sukchan-0811 sukchan-0811 added bug Something isn't working frontend Feature implementation for frontend labels Dec 7, 2023
@sukchan-0811 sukchan-0811 requested a review from JH747 December 7, 2023 03:44
@sukchan-0811
Copy link
Contributor Author

sukchan-0811 commented Dec 9, 2023

백업 시 자동백업 필드 추가, 상징 선택 페이지에서 탭 이동 UI 개선 (관련 이슈: #108)도 이 브랜치에서 했습니다.

@JH747 JH747 merged commit e4352ff into main Dec 9, 2023
1 check passed
@JH747 JH747 deleted the hotfix/db-init branch December 9, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Feature implementation for frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants