Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

설정 백업시 '자동백업' 여부 추가 #113

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

yjeong-k
Copy link
Contributor

@yjeong-k yjeong-k commented Dec 9, 2023

PR Title: 설정 백업시 '자동백업' 여부 추가

Related Issue(s):

#58

PR Description:

설정 백업시 '자동백업' 여부 추가
auto_backup field를 백업에 사용하는 GET, POST 둘 다에 추가했고
default 값은 자동백업 허용인 1로 설정함

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@yjeong-k yjeong-k added the backend Feature implementation for backend label Dec 9, 2023
@yjeong-k yjeong-k self-assigned this Dec 9, 2023
@yjeong-k
Copy link
Contributor Author

yjeong-k commented Dec 9, 2023

이거 머지되면 세팅백업 때 auto_backup 필드값을 무조건 받도록 되어있기 때문에 프론트에서도 맞춰서 꼭 수정이 되어야 합니다

@sukchan-0811
Copy link
Contributor

@JH747 @yjeong-k hotfix/db-init 브랜치에 autobackup 필드 방금 추가했고 제대로 작동하는 거 확인했습니다!

@JH747
Copy link
Contributor

JH747 commented Dec 9, 2023

감사합니다.

@yjeong-k yjeong-k merged commit 4f9d1fc into main Dec 9, 2023
1 check passed
@yjeong-k yjeong-k deleted the feat/add-auto-backup branch December 9, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Feature implementation for backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants