Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/fix not running #117

Merged
merged 10 commits into from
Dec 9, 2023
Merged

Test/fix not running #117

merged 10 commits into from
Dec 9, 2023

Conversation

paul2126
Copy link
Contributor

@paul2126 paul2126 commented Dec 9, 2023

PR Title: fix test not running issue

Related Issue(s):

  • 저희 db-init에서 구조가 바뀌다보니 테스트 코드에 문제가 생겨서 아예 실행이 안되는 현상이 있습니다

PR Description:

  • hotfix/db-init으로부터 브랜치 파서 작업했습니다
  • 문제가 되는 테스트 코드 부분을 삭제했습니다
  • test 파일 전체를 돌려봤는데 8개 실패 240개 통과가 나옵니다
  • 몇몇 실패하는 테스트는 개별로 돌렸을때는 문제가 없지만 같이 돌리면 문제가 되는 경우라서 확인하기 어려울 것 같습니다...

image

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@paul2126 paul2126 added bug Something isn't working test labels Dec 9, 2023
@JH747
Copy link
Contributor

JH747 commented Dec 9, 2023

제가 했을 때는 6개가 fail 했는데 어쩔 수 없죠.
고생하셨습니다.

@JH747 JH747 merged commit c96d552 into main Dec 9, 2023
1 check passed
@JH747 JH747 deleted the test/fix-not-running branch December 9, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants