Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/integration others #119

Merged
merged 11 commits into from
Dec 9, 2023
Merged

Test/integration others #119

merged 11 commits into from
Dec 9, 2023

Conversation

JH747
Copy link
Contributor

@JH747 JH747 commented Dec 9, 2023

PR Title: [Descriptive title summarizing the change]

Related Issue(s):

Link or reference any related issues or tickets.

PR Description:

[Provide a brief summary of the changes made.]

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@JH747 JH747 self-assigned this Dec 9, 2023
@prime2do
Copy link
Contributor

prime2do commented Dec 9, 2023

SymbolSelectionScreenTest에서 몇 개 테스트들이 fail합니다.
TextToSpeechScreenTest는 fail했었는데 다시 돌리니까 통과가 됩니다.
나머지들은 괜찮은 것 같습니다.
AccountSettingsScreenTest, MainSettingsScreenTest, GuestSettingsScreenTest에서 빨간줄 떠서 테스트가 안 돌아서 다른 테스트들도 잘 안 도는 것 같은데, 잘 돌아갔나요?

@JH747
Copy link
Contributor Author

JH747 commented Dec 9, 2023

빨간줄 떠서 안도는 것들은 해당 테스트들이 이전 버전에서 작성되어서 그렇습니다. 명현님이 해당 테스트들 수정하신게 이미 메인에 머지되어 있으니 병합하면 그 부분은 최신 버전으로 알아서 교체될 겁니다.
SymbolSelectionScreenTest에서 한 개 테스트가 fail하는 건 맞습니다. 그건... 그냥 무시해주세요

Copy link
Contributor

@prime2do prime2do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@prime2do prime2do merged commit b697580 into main Dec 9, 2023
1 check passed
@prime2do prime2do deleted the test/integration-others branch December 9, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants