Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/Implement TTS feature #13

Merged
merged 7 commits into from
Oct 29, 2023
Merged

feat/Implement TTS feature #13

merged 7 commits into from
Oct 29, 2023

Conversation

paul2126
Copy link
Contributor

@paul2126 paul2126 commented Oct 28, 2023 •
edited by sukchan-0811
Loading

PR Title: Implement TTS feature

Related Issue(s):

PR Description:

  • Implemented TTS screen
  • Currently pressing guest login button connects to TTS screen
  • Changed the textfield to be scrollable
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@paul2126 paul2126 changed the title ✨ Implement TTS feature feat/Implement TTS feature Oct 28, 2023
@sukchan-0811 sukchan-0811 added the frontend Feature implementation for frontend label Oct 28, 2023
sukchan-0811
sukchan-0811 requested changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@sukchan-0811 sukchan-0811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 재생 버튼 / 정지 버튼 둘 중 하나만 보이게 구현
  2. viewmodel -> repository -> datasource 흐름 유지

이 두 개를 해주시면 좋을 것 같은데 일단은 데모를 위해서 1이 더 급하긴 합니다!

frontend/app/src/main/java/com/example/speechbuddy/compose/SpeechBuddyApp.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/viewmodel/TextToSpeechViewModel.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/ui/models/TextToSpeechUiState.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/compose/landing/LandingScreen.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/compose/SpeechBuddyApp.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/compose/texttospeach/TextToSpeachScreen.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/compose/texttospeach/TextToSpeachScreen.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/compose/texttospeach/TextToSpeachScreen.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/compose/texttospeach/TextToSpeachScreen.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/compose/texttospeach/TextToSpeachScreen.kt Outdated Show resolved Hide resolved
sukchan-0811
sukchan-0811 requested changes Oct 29, 2023
View reviewed changes
frontend/app/src/main/java/com/example/speechbuddy/compose/texttospeech/TextToSpeechScreen.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/compose/texttospeech/TextToSpeechScreen.kt Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/ui/models/TextToSpeechUiState.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/viewmodel/TextToSpeechViewModel.kt Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/viewmodel/TextToSpeechViewModel.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/viewmodel/TextToSpeechViewModel.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/viewmodel/TextToSpeechViewModel.kt Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/viewmodel/TextToSpeechViewModel.kt Outdated Show resolved Hide resolved
frontend/app/src/main/java/com/example/speechbuddy/viewmodel/TextToSpeechViewModel.kt Outdated Show resolved Hide resolved
frontend/app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@paul2126 @sukchan-0811
Apply suggestions from code review
c90c6e6 
Co-authored-by: 이석찬 / Lee Sukchan <[email protected]>
paul2126
paul2126 commented Oct 29, 2023
View reviewed changes
Copy link
Contributor Author

@paul2126 paul2126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 다 적용했습니다!
버튼 뺄 때 context랑 변수를 다 내려주는 방식을 생각했는데 보여주신 방식이 훨씬 깔끔해서 그대로 적용했습니다.

@yjeong-k
Copy link
Contributor

민영님이 말씀해주신 게 있어서 반영해서 커밋 간단한 거 하나 추가했습니다!
다른 브랜치 파기가 그래서..ㅎㅎ 여기다 같이 올리게되었어요
isValidEmail() 자체가 empty input 체크를 해줘서 수정했습니다

@sukchan-0811 sukchan-0811 requested a review from JH747 October 29, 2023 15:12
@sukchan-0811 sukchan-0811 merged commit 1c9890a into main Oct 29, 2023
1 check passed
@sukchan-0811 sukchan-0811 deleted the feat/tts-implementation-frontend branch October 29, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukchan-0811 sukchan-0811 sukchan-0811 approved these changes

@JH747 JH747 Awaiting requested review from JH747

Assignees

@paul2126 paul2126

Labels
frontend Feature implementation for frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul2126 @yjeong-k @sukchan-0811