Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backup 2 backend #14

Merged
merged 14 commits into from
Oct 30, 2023
Merged

Feat/backup 2 backend #14

merged 14 commits into from
Oct 30, 2023

Conversation

yjeong-k
Copy link
Contributor

@yjeong-k yjeong-k commented Oct 29, 2023

PR Title: Implement Backup APIs

Related Issue(s):

  • weight table 백업은 프론트 구현 완료 후 구현할 예정
  • request의 param이나 body 형식 관련해서는 프론트 구현하며 수정 가능(이 부분은 프론트 구현할 때 제가 해볼게요)

PR Description:

  1. Implemented the following APIs
    POST symbol/backup/ : 내상징등록하기 누를 때 부르는 API, 상징 객체 생성
    GET symbol/ : 아래 POST symbol/enable/ 통해 is_valid==True가 된 내상징목록과 그 정보 들고오기
    GET symbol/int:pk/ : pk를 id로 가지는 내상징 정보 들고오기
    POST symbol/enable/ : param으로 전달된 id 값들을 토대로, param에 있는 심볼은 is_valid를 True로 만들고 없는 심볼은 삭제
    POST symbol/favorite/backup/ : request body대신 param으로 값 받아오게 수정
    자세한 사항은 wiki API specifications 참조

  2. 유저 탈퇴 시 해당 유저의 내상징 이미지를 s3에서 삭제

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

@yjeong-k yjeong-k added the backend Feature implementation for backend label Oct 29, 2023
@yjeong-k yjeong-k requested a review from sukchan-0811 October 29, 2023 07:58
@yjeong-k
Copy link
Contributor Author

아까 이야기 나눈 query_param 형식 관련해서 수정한 커밋 추가하였습니다😊

@yjeong-k yjeong-k closed this Oct 30, 2023
@yjeong-k yjeong-k deleted the feat/backup-2-backend branch October 30, 2023 14:36
@yjeong-k yjeong-k restored the feat/backup-2-backend branch October 30, 2023 14:38
@yjeong-k yjeong-k reopened this Oct 30, 2023
@sukchan-0811 sukchan-0811 merged commit 93c9bd9 into main Oct 30, 2023
2 checks passed
@sukchan-0811 sukchan-0811 deleted the feat/backup-2-backend branch October 30, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Feature implementation for backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants