Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/authService implement test #21

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Conversation

paul2126
Copy link
Contributor

@paul2126 paul2126 commented Nov 3, 2023

PR Title: authService implement test

Related Issue(s):

PR Description:

  • Implement authService test
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@paul2126 paul2126 added the frontend Feature implementation for frontend label Nov 3, 2023
Copy link
Contributor

@sukchan-0811 sukchan-0811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 구조 좀 바꾸고 warning 안 뜨게 오타 같은 거 고쳤습니다

중요: @after 처리 작업 필요 없는지 확인 한번 부탁드립니다!

Co-authored-by: 이석찬 / Lee Sukchan <[email protected]>
Copy link
Contributor Author

@paul2126 paul2126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 부분까지 확인해주셔서 감사해요!

@sukchan-0811 sukchan-0811 merged commit d846fa9 into main Nov 3, 2023
1 check passed
@sukchan-0811 sukchan-0811 deleted the test/authService-frontend branch November 3, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Feature implementation for frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants