-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor tts screen and auto deletion #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스크린에서 재생하기 버튼이랑 지우기 버튼 UI 조금 바꾸면 좋을 것 같아요
일단 지금 텍스트랑 아이콘이랑 vertical alignment가 안 맞고
지우기 버튼은 텍스트가 비어있을 때는 비활성화(실제로 비활성화 + 누를 수 없다는 걸 사용자에게 표시)하면 좋을 것 같습니다
지금은 TextClearButton도 TTSButton이랑 똑같은 buttonstatus랑 onplay, onstop 인자를 받는데 이 부분을 수정해야 할 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버튼이 눌렸을 때 위아래 모션 효과 높이가 같으면 좋을 것 같아요
PR Title: Refactor tts screen and auto deletion
Related Issue(s):
PR Description:
Removed auto deletion. Added manual deletion button, which is activated when the speech is not being spoken. Reduced the size of textfield.
Changes Included:
Notes for Reviewer:
Reviewer Checklist:
Additional Comments: