Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor tts screen and auto deletion #36

Merged
merged 10 commits into from
Nov 15, 2023
Merged

Conversation

prime2do
Copy link
Contributor

PR Title: Refactor tts screen and auto deletion

Related Issue(s):

PR Description:

Removed auto deletion. Added manual deletion button, which is activated when the speech is not being spoken. Reduced the size of textfield.

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

@prime2do prime2do requested a review from JH747 November 10, 2023 08:20
Copy link
Contributor

@sukchan-0811 sukchan-0811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린에서 재생하기 버튼이랑 지우기 버튼 UI 조금 바꾸면 좋을 것 같아요
일단 지금 텍스트랑 아이콘이랑 vertical alignment가 안 맞고
지우기 버튼은 텍스트가 비어있을 때는 비활성화(실제로 비활성화 + 누를 수 없다는 걸 사용자에게 표시)하면 좋을 것 같습니다
지금은 TextClearButton도 TTSButton이랑 똑같은 buttonstatus랑 onplay, onstop 인자를 받는데 이 부분을 수정해야 할 것 같아요!

Copy link
Contributor

@paul2126 paul2126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버튼이 눌렸을 때 위아래 모션 효과 높이가 같으면 좋을 것 같아요

@yjeong-k yjeong-k merged commit 030281e into main Nov 15, 2023
1 check passed
@yjeong-k yjeong-k deleted the feat/refactor-tts branch November 15, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants