Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/symbolselectionviewmodel #46

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

paul2126
Copy link
Contributor

PR Title: Test/symbolselectionviewmodel

Related Issue(s):

  • Auth repo test / Symbol repo test / Login viewmodel test requires refactoring to match current files
  • 2 unfixed errors in Symbol selection viewmodel test that is able to run on individual functions but fails on batch test

PR Description:

  • Add Symbol Selection view model test
  • commented out tests that needs refactoring
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@paul2126 paul2126 added the frontend Feature implementation for frontend label Nov 19, 2023
@paul2126
Copy link
Contributor Author

symbolselectionViewModelTest외에 주석 처리한 부분은 예전에 작성된 테스트 코드라 refactor하면서 문법이 맞지 않게된 부분을 주석처리한 부분입니다. 그래서 authRepoTest, LoginViewModel, SymbolRepoTest모두 refactor진행해야합니다. 그리고 주석에서 크게 바뀌지 않을 것 같은 부분들도 많아서 주석은 그대로 두셔도 될 것 같아요

@89645321
Copy link
Contributor

symbolselectionViewModelTest외에 주석 처리한 부분은 예전에 작성된 테스트 코드라 refactor하면서 문법이 맞지 않게된 부분을 주석처리한 부분입니다. 그래서 authRepoTest, LoginViewModel, SymbolRepoTest모두 refactor진행해야합니다. 그리고 주석에서 크게 바뀌지 않을 것 같은 부분들도 많아서 주석은 그대로 두셔도 될 것 같아요

symbolselectionviewmodel도 테스트가 완성된 게 아닌 게 맞나요?

@paul2126
Copy link
Contributor Author

symbolselectionViewModelTest외에 주석 처리한 부분은 예전에 작성된 테스트 코드라 refactor하면서 문법이 맞지 않게된 부분을 주석처리한 부분입니다. 그래서 authRepoTest, LoginViewModel, SymbolRepoTest모두 refactor진행해야합니다. 그리고 주석에서 크게 바뀌지 않을 것 같은 부분들도 많아서 주석은 그대로 두셔도 될 것 같아요

symbolselectionviewmodel도 테스트가 완성된 게 아닌 게 맞나요?

네 해당 테스트도 완성 안 된게 맞습니다

@89645321 89645321 merged commit 42bb13d into main Nov 22, 2023
1 check passed
@89645321 89645321 deleted the test/symbolselectionviewmodel branch November 22, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Feature implementation for frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants