Feat/onapp take photo #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89645321
reviewed
Nov 23, 2023
...end/app/src/main/java/com/example/speechbuddy/compose/symbolcreation/SymbolCreationScreen.kt
Outdated
Show resolved
Hide resolved
89645321
reviewed
Nov 23, 2023
...end/app/src/main/java/com/example/speechbuddy/compose/symbolcreation/SymbolCreationScreen.kt
Outdated
Show resolved
Hide resolved
89645321
reviewed
Nov 23, 2023
89645321
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title: Implement onapp take photo feature
Related Issue(s):
PR Description:
Clicking the AddPhotoButton pops up the PhotoOptionDialog.
User can choose to take photo or to select a photo from gallery.
User can dismiss the dialog either by clicking the cancel button, or touching any area outside the dialog.
Changes Included:
Notes for Reviewer:
Reviewer Checklist:
Additional Comments:
The 'stringResource(id = R.string.cancel)' is a string resource that is not included in symbolCreation part, but to avoid conflict, I just used it. I would change it if necessary.