Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 비밀번호 확인란에 keyboard type: password 적용 #67

Merged
merged 2 commits into from
Nov 25, 2023
Merged

feat: 비밀번호 확인란에 keyboard type: password 적용 #67

merged 2 commits into from
Nov 25, 2023

Conversation

paul2126
Copy link
Contributor

PR Title: 비밀번호 확인란에 keyboard type: password 적용

Related Issue(s):

Link or reference any related issues or tickets.

PR Description:

  • 비밀번호 확인란에 keyboard type: password 적용
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Any specific instructions or points to be considered by the
reviewer.

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

@paul2126 paul2126 added the frontend Feature implementation for frontend label Nov 25, 2023
@paul2126 paul2126 requested review from 89645321 and JH747 November 25, 2023 06:29
89645321
89645321 requested changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@89645321 89645321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

비밀번호 변경 페이지에도 필드 둘 다 옵션 넣어주실 수 있으실까요?

@paul2126
Copy link
Contributor Author

비밀번호 변경 페이지에도 필드 둘 다 옵션 넣어주실 수 있으실까요?

넣은줄 알았는데 안 넣었었군요. 방금 추가했습니다!

@89645321 89645321 merged commit 9b0213d into main Nov 25, 2023
1 check passed
@89645321 89645321 deleted the feat/add-password-field-setting branch November 25, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@89645321 89645321 89645321 approved these changes

@JH747 JH747 Awaiting requested review from JH747

Assignees

@paul2126 paul2126

@prime2do prime2do

Labels
frontend Feature implementation for frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul2126 @89645321 @prime2do