Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/darkmode #68

Merged
merged 1 commit into from
Nov 26, 2023
Merged

fix/darkmode #68

merged 1 commit into from
Nov 26, 2023

Conversation

89645321
Copy link
Contributor

@89645321 89645321 commented Nov 25, 2023

PR Title: Fix dark mode bug

Related Issue(s):

PR Description:

다크 모드가 적용되는 방식을 아예 바꿨습니다. 기존에는 activity를 recreate하는 방식으로 다크 모드를 바꿨는데, 그렇게 하니 너무 버그가 많이 생겨 SpeechbuddyTheme을 수정해서 activity가 create되지 않고(아마...) 다크 모드가 적용되도록 바꿨습니다.

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

바꾸면서 speechbuddyTheme에 settingsRepository를 넣어주게 되어서 preview를 다 지웠습니다

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

@89645321 89645321 added bug Something isn't working frontend Feature implementation for frontend labels Nov 25, 2023
Copy link
Contributor

@yjeong-k yjeong-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세팅 페이지에서 다크 모드 선택하면 오류없이 바로 반영되는 것 확인하였습니다!
고생많으셨습니다 민영님...!!!🥹👍

@yjeong-k yjeong-k merged commit bf7d66c into main Nov 26, 2023
1 check passed
@yjeong-k yjeong-k deleted the fix/darkmode branch November 26, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Feature implementation for frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants