Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight table 초기값 추가 #80

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Weight table 초기값 추가 #80

merged 2 commits into from
Nov 29, 2023

Conversation

paul2126
Copy link
Contributor

@paul2126 paul2126 commented Nov 29, 2023

PR Title: Weight table 초기값 추가

Related Issue(s):

PR Description:

  • Weight table 초기값 추가
Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:
  • 150 단어가 누락되어있고 해당 사항의 경우 0으로 처리했습니다.
  • 음수도 포함되어있어서 최소값이 0이 아닙니다
  • 다음 단어를 예측할 때 올 만한 단어를 예측하기 보다 비슷한 단어를 선택합니다. 다만 word2vec의 단어 벡터의 코사인 유사도만 사용해서 weight table을 만들다보니 어쩔 수 없는 문제로 사용하면서 사용자가 데이터를 입력하는 방법밖에 없습니다...
  • 현재는 int(코사인 유사도100)를 하고있는데 유저가 너무 데이터를 많이 넣어야 한다면 int(코사인 유사도10)하고 roundup으로 부담을 줄일 수 있습니다

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

Add any other comments or information that might be useful for the
review process.

Copy link
Contributor

@JH747 JH747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

db에 초기값이 잘 들어가는 것 확인했습니다. 당연하겠지만 providesuggestion도 정상작동합니다. 고생하셨습니다.

@JH747 JH747 merged commit 02530cd into main Nov 29, 2023
1 check passed
@JH747 JH747 deleted the feat/Add-initial-weightTable branch November 29, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants