Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/display-mode #98

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix/display-mode #98

merged 1 commit into from
Dec 4, 2023

Conversation

89645321
Copy link
Contributor

@89645321 89645321 commented Dec 3, 2023

PR Title: fix/display-mode

Related Issue(s):

PR Description:

한 가지 문제 빼고는 다 해결했습니다....그 한 가지 문제는 로그인 직후에는 무조건 symbol page로 가게 된다는 것입니다
정보를 받아오는 데 시간이 좀 걸려서 생기는 문제이고, 해결하려고 다음과 같은 방법을 시도해보았습니다

  1. suspend 사용: oncreate에서 사용할 수 없음
  2. mutable한 자료구조 사용: 처음에 symbol page(기본값)가 좀 보이다가 TTS로 바뀌는 문제 발생, 세팅 페이지에서 display mode를 바꾸는 즉시 SpeechBuddyHome이 불려서 세팅 페이지를 이탈하는 문제 발생

바꾸려면 datastore를 안 쓰는 쪽으로 아예 구조를 엎어야 할 것 같아서 그냥 두겠습니다...로그인 직후를 제외하면 자동 로그인이 일어날 시에는 다 정상 작동하는 것 확인했습니다

Changes Included:
  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation
Notes for Reviewer:

Reviewer Checklist:

  • Code is written in clean, maintainable, and idiomatic form.
  • Automated test coverage is adequate.
  • All existing tests pass.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments:

@89645321 89645321 self-assigned this Dec 3, 2023
Copy link
Contributor

@JH747 JH747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인했고 언급하신 조건에서 언급하신 대로 작동하는 것 확인하였습니다.
고생하셨습니다.

@JH747 JH747 merged commit 8c59c1c into main Dec 4, 2023
1 check passed
@JH747 JH747 deleted the fix/display-mode branch December 4, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants