Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: adding https scheme for liveness and readiness probe[HYB-475] #108

Closed
wants to merge 1 commit into from
Closed

bug: adding https scheme for liveness and readiness probe[HYB-475] #108

wants to merge 1 commit into from

Conversation

saumilmac
Copy link
Contributor

What:

  • Adding HTTPS scheme for Liveness and Readiness prob when TLS certs are defined.

Why:

  • liveness probe and readiness probe are not configured to use HTTPS in current broker deployment

@saumilmac saumilmac requested a review from a team as a code owner March 13, 2024 15:11
@saumilmac saumilmac changed the title bug: adding https scheme for liveness and readiness probe bug: adding https scheme for liveness and readiness probe[HYB-475] Mar 13, 2024
soniqua
soniqua requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@soniqua soniqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • bug: isn't a valid prefix
  • Please ensure any snapshots are updated

@saumilmac saumilmac closed this Mar 13, 2024
@saumilmac saumilmac deleted the bug/add-https-for-liveness-probe branch March 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soniqua soniqua soniqua requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saumilmac @soniqua