Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: specify chart version for tests snapshots #115

Merged
merged 2 commits into from
Apr 11, 2024
Merged

chore: specify chart version for tests snapshots #115

merged 2 commits into from
Apr 11, 2024

Conversation

pavel-snyk
Copy link
Contributor

Small quality of life test improvement. We specify chart.version in unit tests, so snapshots do not have to be updated when we release a new version.

How the unit tests will/should look like:

suite: test bla-bla-bla
chart:
  version: 0.0.0  # <- this renders a fixed version in snapshots.
templates:
...

@pavel-snyk pavel-snyk requested review from a team as code owners April 10, 2024 22:30
jonnyowenpowell
jonnyowenpowell approved these changes Apr 11, 2024
View reviewed changes
Copy link

@jonnyowenpowell jonnyowenpowell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍
💯 for having newline at EOF settings right

@soniqua soniqua merged commit 08d049f into main Apr 11, 2024
4 checks passed
@soniqua soniqua deleted the chore/specify-chart-version-for-tests-snapshots branch April 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyowenpowell jonnyowenpowell jonnyowenpowell approved these changes

@soniqua soniqua soniqua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-snyk @soniqua @jonnyowenpowell