Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for external secrets #133

Closed
wants to merge 3 commits into from

Conversation

DrackThor
Copy link

What:

  • enable support for providing broker token, snyk token and scm token via external secret

Why:

  • I don't want to have to put my secret values in a values.yaml stored in git when deploying via gitops

@DrackThor DrackThor requested a review from a team as a code owner August 30, 2024 07:38
@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@DrackThor DrackThor force-pushed the feat/external-secret branch from 15ce201 to 2ddcf73 Compare August 30, 2024 07:41
@soniqua
Copy link
Contributor

soniqua commented Aug 30, 2024

Hi @DrackThor - thanks for your contribution to the Snyk Broker Helm repo.

We've been working internally on a similar solution, and I've had time to push that up today (#134). I think that should satisfy the need you outline here, and maintain backwards compatibility with how names were generated with previous versions of the chart.

@DrackThor
Copy link
Author

@soniqua great to hear that! In that case I'll close this PR since the feature was added meanwhile.

@DrackThor DrackThor closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants