refactor: remove unnecessary css #725
Open
+1,098
−927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariusZdroba
force-pushed
the
chore/unify-css-for-code
branch
from
50a0a49
to
76b52eb
Compare
DariusZdroba
temporarily deployed
to
Standard
GitHub Actions
Inactive
DariusZdroba
temporarily deployed
to
Standard
GitHub Actions
Inactive
ShawkyZ
reviewed
Nov 25, 2024
| @@ -20,7 +21,7 @@ | |||
| } | |||
|
|
|||
| ::-webkit-scrollbar-thumb:hover { | |||
| background: var(--scroll-bar-hover-background-color); | |||
| background: var(); | |||
There was a problem hiding this comment.
don't we need the var --scroll-bar-hover-background-color here
DariusZdroba
changed the title
ShawkyZ
reviewed
Nov 25, 2024
ShawkyZ
reviewed
Nov 25, 2024
ShawkyZ
approved these changes
Nov 25, 2024
DariusZdroba
temporarily deployed
to
Standard
GitHub Actions
Inactive
DariusZdroba
temporarily deployed
to
Standard
GitHub Actions
Inactive
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CSS was really cluttered and difficult to understand being in the HTML templates in
<style>tags, I separated them into their own file, now we inject them the same way we did so far with IaC, through the TemplateData that is used to dynamically render variables into the HTML.In addition to that, some minor styling changes were pushed down from VSCode in order to remove them from being plugin-specific and having a more centralized styling possibility in Language Server.
Checklist